refactor(charts/injector): improve upgrade directions for cert reinstallation #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…creation Related to #124 Add expiration check for self-signed certificates in `charts/dsv-injector/templates/webhook.yaml`. * Add a new variable `recreateSelfSignedCertThreshold` with a default of 90 days. * Add a check for the expiration of the existing cert in the next n days. * Update the logic to generate a new self-signed cert if the existing cert is expiring within `recreateSelfSignedCertThreshold` days. * Update the secret cert value mapping to use the `$tlsCert` value based on it meeting the expiration check requirement. Expose `webhookCertExpireDays` and `recreateSelfSignedCertThreshold` in `charts/dsv-injector/values.yaml`. * Expose `webhookCertExpireDays` with a default of 365 days. * Add `recreateSelfSignedCertThreshold` with a default of 90 days. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/DelineaXPM/dsv-k8s/issues/124?shareId=XXXX-XXXX-XXXX-XXXX).
… detection and recreation logic
… detection and recreation logic
…nhancements [skip ci]
sheldonhull
changed the title
tdillenbeck
reviewed
Aug 12, 2024
tdillenbeck
reviewed
Aug 12, 2024
pacificcode
approved these changes
Aug 14, 2024
sheldonhull
deleted the
sheldonhull/refactor/helm-chart-cert-expiration-improvements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #124
webhookCertExpireDayswith a default of 365 days.fixes AB#590946
fixes #124
For more details, open the Copilot Workspace session.